Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cardNavigationBarClass configuration option #19

Merged
merged 1 commit into from Mar 16, 2013

Conversation

dulacp
Copy link
Contributor

@dulacp dulacp commented Mar 16, 2013

Again me with a configuration option ^^

Apple introduce in iOS5 initWithNavigationBarClass:toolbarClass:, a new UINavigationController method to properly customize the navigation bar used.

I think it's important that we can control this aspect of the design. I needed that, to achieve taller cards, like those one.

Capture d e cran du Simulateur iOS 16 mars 2013 01 33 36

Apple introduce in iOS5 a new `UINavigationController` method
`initWithNavigationBarClass:toolbarClass:` to properly customize the
navigation bar used. I think it's important that we can control that
aspect.
KieranLafferty added a commit that referenced this pull request Mar 16, 2013
Add a `cardNavigationBarClass` configuration option
@KieranLafferty KieranLafferty merged commit dd3cf60 into KieranLafferty:master Mar 16, 2013
@dulacp
Copy link
Contributor Author

dulacp commented Mar 16, 2013

Fastest merge on earth :)

@KieranLafferty
Copy link
Owner

haha :) thanks for contributing to the control, much appreciated

@dulacp
Copy link
Contributor Author

dulacp commented Mar 16, 2013

You're welcome. Your project is awesome, I'm using it in one of my app. So not contributing would have been a crime !

@KieranLafferty
Copy link
Owner

awesome be sure to let me know when you are done I would love to see the final product

@dulacp
Copy link
Contributor Author

dulacp commented Mar 16, 2013

Deal! I'll let you know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants